Promote allocation to v1 #881

roberthbailey · 2019-07-09T03:06:11Z

This is part of #703.

/assign @markmandel
/label kind/breaking

agones-bot · 2019-07-09T03:17:16Z

Build Failed 😱

Build Id: aaea0182-0dca-479d-943d-4f6f88dfb5aa

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2019-07-09T03:43:47Z

Looks like you need a make gen-install 😄

roberthbailey · 2019-07-09T04:01:39Z

Yes.... sometimes it's hard to tell which files are edited and which are generated.

roberthbailey · 2019-07-09T04:12:27Z

This is likely to need another helm reset too.

agones-bot · 2019-07-09T04:31:10Z

Build Failed 😱

Build Id: 3e8b2c75-701c-4b94-964a-6e9099918e6d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-07-09T04:36:25Z

The last cloud build failed on helm like the previous PR.

agones-bot · 2019-07-09T08:22:47Z

Build Failed 😱

Build Id: a8277404-4972-4d03-841d-9f79ada6a29f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

A few small things, but overall look good 👍

pkg/apis/allocation/v1/zz_generated.deepcopy.go

site/content/en/docs/Getting Started/create-fleet.md

markmandel · 2019-07-09T19:10:37Z

site/content/en/docs/Guides/access-api.md

@@ -236,11 +236,11 @@ $ curl http://localhost:8001/apis/stable.agones.dev/v1alpha1/namespaces/default/

 # allocate a gameserver from a fleet named 'simple-udp', with GameServerAllocation

-$ curl -d '{"apiVersion":"allocation.agones.dev/v1alpha1","kind":"GameServerAllocation","spec":{"required":{"matchLabels":{"stable.agones.dev/fleet":"simple-udp"}}}}' -H "Content-Type: application/json" -X POST http://localhost:8001/apis/allocation.agones.dev/v1alpha1/namespaces/default/gameserverallocations
+$ curl -d '{"apiVersion":"allocation.agones.dev/v1","kind":"GameServerAllocation","spec":{"required":{"matchLabels":{"stable.agones.dev/fleet":"simple-udp"}}}}' -H "Content-Type: application/json" -X POST http://localhost:8001/apis/allocation.agones.dev/v1/namespaces/default/gameserverallocations


we'll need to {{< feature >}} this

Good catch. Fixed.

markmandel · 2019-07-09T19:24:15Z

Deleting the helm install, and rerunning!

agones-bot · 2019-07-09T19:46:28Z

Build Failed 😱

Build Id: 8e31cb19-5d58-4d31-b31c-15af45e72be7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-09T19:54:02Z

Build Failed 😱

Build Id: bcdaa85b-5d38-415e-a9ca-936cba3585df

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-09T20:01:45Z

Build Failed 😱

Build Id: c8c773ad-7ac8-4bce-b644-047b1d743dea

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-10T00:02:57Z

Build Succeeded 👏

Build Id: 116af778-52a6-4056-8d10-61f13a33fd1c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-baf054c
image: gcr.io/agones-images/agones-sdk:0.12.0-baf054c
image: gcr.io/agones-images/agones-ping:0.12.0-baf054c
Linux C++ SDK (build): agonessdk-0.12.0-baf054c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-baf054c.zip

A preview of the website (the last 30 builds are retained):

https://baf054c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/881/head:pr_881 && git checkout pr_881
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-baf054c

agones-bot · 2019-07-10T00:41:36Z

Build Failed 😱

Build Id: eddad440-1c4b-4a1e-8b06-f28234e204b1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-07-10T03:20:17Z

I'm seeing a weird error on the e2e tests:

Already have image: e2e-runner
cp: cannot stat '/workspace/./build/.gomod/cache/vcs/b9a4b9bbdb4a59723f2348415ad7ffda91568455a1cfd92e97976132bdfbaf57/shallow.lock': No such file or directory

This doesn't seem related to my change and I'm not sure how to fix it.

markmandel · 2019-07-10T03:22:46Z

I think Cloud Build is having a sad. Will retry shortly.

agones-bot · 2019-07-10T03:24:57Z

Build Failed 😱

Build Id: 5326b151-4ec2-4765-9433-50cd23482c7d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-10T03:27:54Z

Build Failed 😱

Build Id: 65672089-5f34-41f6-9dc6-0b7cf6dfb421

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2019-07-10T03:29:34Z

Yep,, definite sad.

agones-bot · 2019-07-10T04:05:51Z

Build Failed 😱

Build Id: f3795921-3f1b-49c2-bbd7-bfdf93424a10

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-10T04:49:05Z

Build Failed 😱

Build Id: 1367c36f-d8ce-4eda-9334-1ee448b3b402

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-10T09:04:03Z

Build Succeeded 👏

Build Id: 6c7faa2b-94a9-403c-bace-b8eb9dc81af5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-549d248
image: gcr.io/agones-images/agones-sdk:0.12.0-549d248
image: gcr.io/agones-images/agones-ping:0.12.0-549d248
Linux C++ SDK (build): agonessdk-0.12.0-549d248-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-549d248.zip

A preview of the website (the last 30 builds are retained):

https://549d248-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/881/head:pr_881 && git checkout pr_881
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-549d248

roberthbailey · 2019-07-10T09:04:25Z

I was having trouble reproducing this failure locally:

$ make test-e2e
...
ok  	agones.dev/agones/test/e2e	551.763s
echo "Finishing e2e test runner!"
Finishing e2e test runner!

and for some reason after a few re-tries cloud build is now working too.

markmandel

👍 awesome.

agones-bot · 2019-07-10T20:16:56Z

Build Succeeded 👏

Build Id: 8b666f00-09ad-4e38-a3be-6037cdbc3560

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-ff3203e
image: gcr.io/agones-images/agones-sdk:0.12.0-ff3203e
image: gcr.io/agones-images/agones-ping:0.12.0-ff3203e
Linux C++ SDK (build): agonessdk-0.12.0-ff3203e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-ff3203e.zip

A preview of the website (the last 30 builds are retained):

https://ff3203e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/881/head:pr_881 && git checkout pr_881
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-ff3203e

markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/breaking Breaking change kind/feature New features for Agones labels Jul 9, 2019

roberthbailey force-pushed the allocation-to-v1 branch from 63931ae to 553868b Compare July 9, 2019 08:03

markmandel reviewed Jul 9, 2019

View reviewed changes

roberthbailey force-pushed the allocation-to-v1 branch 3 times, most recently from 63245de to a2fc27d Compare July 9, 2019 19:33

roberthbailey force-pushed the allocation-to-v1 branch from a2fc27d to baf054c Compare July 9, 2019 23:43

roberthbailey force-pushed the allocation-to-v1 branch from baf054c to 4b6f3f9 Compare July 10, 2019 00:29

roberthbailey added 7 commits July 9, 2019 20:15

Rename the allocation API from v1alpha1 -> v1.

cc0896b

Run make gen-crd-client.

4556ea3

Code updated for the new allocation import path.

f3aa19f

Updates for the new allocation api version.

4b4facf

Force a rebuild of the build image.

e975a34

Update website docs.

b61807e

Run make gen-api-docs.

05f3264

Run make gen-install.

549d248

roberthbailey force-pushed the allocation-to-v1 branch from 4b6f3f9 to 549d248 Compare July 10, 2019 03:15

markmandel approved these changes Jul 10, 2019

View reviewed changes

markmandel added 2 commits July 10, 2019 12:27

Merge branch 'master' into allocation-to-v1

eb6d1e1

Merge branch 'master' into allocation-to-v1

ff3203e

markmandel merged commit 194293e into googleforgames:master Jul 10, 2019

markmandel added this to the 0.12.0 milestone Jul 10, 2019

roberthbailey mentioned this pull request Jul 16, 2019

Approver access for @roberthbailey #914

Closed

5 tasks

roberthbailey deleted the allocation-to-v1 branch August 1, 2019 16:27

roberthbailey mentioned this pull request Aug 15, 2019

Revert the change to promote the service for multicluster allocation to v1 #1001

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote allocation to v1 #881

Promote allocation to v1 #881

roberthbailey commented Jul 9, 2019

agones-bot commented Jul 9, 2019

markmandel commented Jul 9, 2019

roberthbailey commented Jul 9, 2019

roberthbailey commented Jul 9, 2019

agones-bot commented Jul 9, 2019

roberthbailey commented Jul 9, 2019

agones-bot commented Jul 9, 2019

markmandel left a comment

markmandel Jul 9, 2019

roberthbailey Jul 9, 2019

markmandel commented Jul 9, 2019

agones-bot commented Jul 9, 2019

agones-bot commented Jul 9, 2019

agones-bot commented Jul 9, 2019

agones-bot commented Jul 10, 2019

agones-bot commented Jul 10, 2019

roberthbailey commented Jul 10, 2019

markmandel commented Jul 10, 2019

agones-bot commented Jul 10, 2019

agones-bot commented Jul 10, 2019

markmandel commented Jul 10, 2019

agones-bot commented Jul 10, 2019

agones-bot commented Jul 10, 2019

agones-bot commented Jul 10, 2019

roberthbailey commented Jul 10, 2019

markmandel left a comment

agones-bot commented Jul 10, 2019

Promote allocation to v1 #881

Promote allocation to v1 #881

Conversation

roberthbailey commented Jul 9, 2019

agones-bot commented Jul 9, 2019

markmandel commented Jul 9, 2019

roberthbailey commented Jul 9, 2019

roberthbailey commented Jul 9, 2019

agones-bot commented Jul 9, 2019

roberthbailey commented Jul 9, 2019

agones-bot commented Jul 9, 2019

markmandel left a comment

Choose a reason for hiding this comment

markmandel Jul 9, 2019

Choose a reason for hiding this comment

roberthbailey Jul 9, 2019

Choose a reason for hiding this comment

markmandel commented Jul 9, 2019

agones-bot commented Jul 9, 2019

agones-bot commented Jul 9, 2019

agones-bot commented Jul 9, 2019

agones-bot commented Jul 10, 2019

agones-bot commented Jul 10, 2019

roberthbailey commented Jul 10, 2019

markmandel commented Jul 10, 2019

agones-bot commented Jul 10, 2019

agones-bot commented Jul 10, 2019

markmandel commented Jul 10, 2019

agones-bot commented Jul 10, 2019

agones-bot commented Jul 10, 2019

agones-bot commented Jul 10, 2019

roberthbailey commented Jul 10, 2019

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Jul 10, 2019